Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out HF types #47

Open
alastairong1 opened this issue Aug 22, 2024 · 0 comments
Open

Figure out HF types #47

alastairong1 opened this issue Aug 22, 2024 · 0 comments

Comments

@alastairong1
Copy link
Contributor

We import hpos-hc-connect which contains Holofuel types, but we ignore them and redefine them here.

Furthermore, there are some inconsistencies in their definitions. For example in this repo Ledger struct fields are of type Fuel whereas in hpos-hc-connect they are of type string.

Copying a short conversation from PJ and Joel on the matter:

PJ:
Those are holofuel - specific types I think and because holofuel does not expose public crate with those types we are just manually defining them in the code of both hpos-api-rust and hpos_hc_connect. Shall we define them in one and import to another? I don't think so because they are holofuel specific and the only proper solution would be to make them available via holofuel types crate.
Joel:
I agree with this in general, but its a lot of work to extract it from the transactor_integrity zome. (I wish it was easier, zippy has tried it too) Thats why we created it in hpos_hc_connect for now.

https://github.com/Holo-Host/holofuel/pull/178 was may attempt to extract it fro the transactor_integrity zome, but its not completed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant