Revert JSON v3 logic #1704
Merged
Revert JSON v3 logic #1704
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hasn't been used in a around 8 months since the approach didn't work as well as we initially hoped. The idea was to reduce the size of the JSON blob to improve performance. This PR essentially reverts the following 2 commits: - 439c237 - 8e4d934 Related Links: - New approach: Homebrew/brew#19204 - Old approach: Homebrew/brew#16410
7 tasks
MikeMcQuaid
approved these changes
Feb 6, 2025
|
Thanks @apainintheneck! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasn't been used in a around 8 months since the approach didn't work as well as we initially hoped so we're removing it per Homebrew/brew#19204 (comment).
It should be safe to just remove this since it means that we're not archiving some generated files and not signing the files that are no longer being archived. In a follow-up PR, I'll remove the generation logic for the JSON files that no longer need to be updated from the main Brew repo.
This PR essentially reverts the following 2 commits:
Related Links:
CC: @Rylan12 since you might want to add some logic like this in the future to sign other JSON files.