Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macho: FatArch64 support #103

Merged
merged 1 commit into from
Aug 4, 2018
Merged

macho: FatArch64 support #103

merged 1 commit into from
Aug 4, 2018

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Jul 8, 2018 •
edited
Loading

TODO:

  • Update FatFile#new_from_machos to allow emission of FatArch64.

Closes #101.

@woodruffw
Copy link
Member Author

I ended up going the same route as lipo, erroring (throwing an exception) if the user attempts to create a fat Mach-O without explicitly requesting fat_arch_64. This is much simpler to implement, and much more efficient than the transparent upgrade from fat_arch to fat_arch_64 would have been.

@woodruffw woodruffw changed the title [WIP] macho: FatArch64 support macho: FatArch64 support Aug 3, 2018
@woodruffw woodruffw merged commit 1534cbb into master Aug 4, 2018
@woodruffw woodruffw deleted the fat-arch-64 branch August 4, 2018 02:55
@lock lock bot added the outdated label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FatArch64
1 participant
@woodruffw