Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headers: Add ARM64_32 constants #114

Merged
merged 1 commit into from
Sep 26, 2018
Merged

headers: Add ARM64_32 constants #114

merged 1 commit into from
Sep 26, 2018

Conversation

woodruffw
Copy link
Member

Based on binary samples, it looks like CPU_TYPE_ARM64_32 is the same
constant as CPU_TYPE_ARM, ORed with a new ABI flag
(0x02000000, instead of 0x01000000 for CPU_ARCH_ABI64). Similarly,
the only CPU subtype seen so far appears to be a direct copy of
CPU_SUBTYPE_ARM64_V8 and CPU_SUBTYPE_ARM_V8 (0x1).

Fixes #113.

Based on binary samples, it looks like CPU_TYPE_ARM64_32 is the same
constant as CPU_TYPE_ARM, ORed with a new ABI flag
(0x02000000, instead of 0x01000000 for CPU_ARCH_ABI64). Similarly,
the only CPU subtype seen so far appears to be a direct copy of
CPU_SUBTYPE_ARM64_V8 and CPU_SUBTYPE_ARM_V8.

Fixes #113.
@woodruffw woodruffw added the bug label Sep 26, 2018
@woodruffw woodruffw self-assigned this Sep 26, 2018
@woodruffw
Copy link
Member Author

@shekhar-suman The changes in this branch work for me locally on openssl, so I'm going to merge once the CI goes through. After that, we'll probably need to bump the version of ruby-macho that CocoaPods uses.

@shekhar-suman
Copy link

Thanks @woodruffw . ruby-macho is working standalone and able to parse the framework. Because Cocoapods is still dependent on ruby-macho 1.1, can't use it yet. Until they merge your pull request and bump up Cocoapod version and release it.

@lock lock bot added the outdated label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to parse parse dynamic framework if it contains new arm64_32 arch slice
2 participants