MachO::MachOFile#delete_rpath does not work

[carlocab]

If you compile a dylib, say libfoo.dylib and open it using

file = MachO::MachOFile.new("libfoo.dylib")

and then use file.delete_rpath to delete an LC_RPATH entry, nothing happens. I do get a large amount of text in my terminal, but that's from delete_rpath dumping raw_data entries in my terminal.

On the other hand, using MachO::Tools.delete_rpath does seem to work.

I'll try to dig into why one seems to be working when the other doesn't.

[carlocab]

Not sure I understand why this is happening, though, since I think MachO::Tools.delete_rpath just makes use of MachO::MachOFile#delete_rpath:

ruby-macho/lib/macho/tools.rb

Lines 84 to 89 in 20419be

	def self.delete_rpath(filename, old_path, options = {})
	file = MachO.open(filename)
	file.delete_rpath(old_path, options)
	file.write!
	end

[carlocab]

Oh, I see. It's the additional write! call that's needed here. This is why delegating delete_rpath never worked properly here:

https://github.com/Homebrew/brew/blob/7c68b1738b3dce2885d0146f327eaaf96b6d0029/Library/Homebrew/os/mac/mach.rb#L13

[carlocab]

This seems to be by design, so I'm closing this.