sections: add Section#type? and Section#attribute?
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This two predicates replace the `Section#flag?` predicate, which has unintuitive behavior and is now deprecated. Closes #423.
Previously, the offset returned by this method could be incidentally wrong, depending on unrelated flags in each section. This changeset fixes the method so that only the section's type is checked, rather than the entire composite flag field.
Introduced by Mach-O at some point.
Clarify that these are masks.
|
cc @iOS-Developer-Sun let me know if these changes work for you. |
Merged
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two predicates replace the
Section#flag?predicate, whichhas unintuitive behavior and is now deprecated.
Closes #423.