Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to pydantic v2 #38

Open
pkdash opened this issue Jul 26, 2023 · 2 comments · May be fixed by #51
Open

Upgrade to pydantic v2 #38

pkdash opened this issue Jul 26, 2023 · 2 comments · May be fixed by #51
Assignees
@pkdash
Labels
enhancement New feature or request

Comments

@pkdash
Copy link
Collaborator

pkdash commented Jul 26, 2023

pydantic v2 provides performance improvements.
@pkdash pkdash self-assigned this Jul 26, 2023
@pkdash pkdash mentioned this issue Aug 6, 2023
Closed
pkdash added a commit that referenced this issue Aug 14, 2023
@pkdash
[#38] initial migration to use pydantic v2
08e8c93
pkdash added a commit that referenced this issue Aug 14, 2023
@pkdash
[#38] pinning dependencies
dca1631
pkdash added a commit that referenced this issue Aug 16, 2023
@pkdash
[#38] updating with develop
00be384
@Maurier Maurier added the enhancement New feature or request label Sep 6, 2023
pkdash added a commit that referenced this issue Sep 12, 2023
@pkdash
[#38] merge branch 'develop' of https://github.com/I-GUIDE/catalogapi …
d997914 
…into 38-update-to-pydantic-v2
pkdash added a commit that referenced this issue Sep 12, 2023
@pkdash
[#38] leaving a note Rocketry is not compatible with pydantic v2 for …
d205fdd 
…scheduler to be upgraded
pkdash added a commit that referenced this issue Sep 12, 2023
@pkdash
[#38] using a custom annotated type for url to string conversion
a0938f0
@pkdash pkdash linked a pull request Sep 19, 2023 that will close this issue
[#38] code migration to use pydantic v2 #51
Open
pkdash added a commit that referenced this issue Sep 21, 2023
@pkdash
[#38] setting default for optional model field
e76482a
pkdash added a commit that referenced this issue Sep 21, 2023
@pkdash
[#38] replacing rocketry (not compatible with pydantic v2) module wit…
cba00f9 
…h apscheduler
pkdash added a commit that referenced this issue Sep 26, 2023
@pkdash
[#38] replacing default_factory with default
ccb107e
pkdash added a commit that referenced this issue Sep 26, 2023
@pkdash
[#38] replacing anyOf for type with type as string in schema generation
c68dd11
pkdash added a commit that referenced this issue Sep 26, 2023
@pkdash
[#38] updating tests to check for field None value
f993e4b
pkdash added a commit that referenced this issue Sep 26, 2023
@pkdash
[#38] updating default for optional list type model fields
a5ca4d4
pkdash added a commit that referenced this issue Sep 26, 2023
@pkdash
[#38] updated json schema for dataset
eaacbde
pkdash added a commit that referenced this issue Oct 10, 2023
@pkdash
[#38] more customization of schema generation
d455438
pkdash added a commit that referenced this issue Oct 10, 2023
@pkdash
[#38] updated schema.json file
4bad6ef
pkdash added a commit that referenced this issue Oct 16, 2023
@pkdash
[#38] removing deprecated Config class
bd69aac
pkdash added a commit that referenced this issue Oct 16, 2023
@pkdash
[#38] updating beanie version to remove pydantic v2 warnings
d761cae
pkdash added a commit that referenced this issue Oct 16, 2023
@pkdash
[#38] custom serialization of url field of Submission model
0f61ba7
pkdash added a commit that referenced this issue Oct 16, 2023
@pkdash
[#38] custom serialization of field of type HttpUrl
67298c5
pkdash added a commit that referenced this issue Oct 16, 2023
@pkdash
[#38] moving extra keys of Field to json_schema_extra
c4c22db
pkdash added a commit that referenced this issue Oct 16, 2023
@pkdash
[#38] making SearchQuery model fields optional
486dba1
pkdash added a commit that referenced this issue Oct 26, 2023
@pkdash
[#38] removing the key 'default' from generated schema if value is nu…
71f7550 
…ll or empty list
pkdash added a commit that referenced this issue Oct 26, 2023
@pkdash
[#38] updated json schema
43d2d0a
pkdash added a commit that referenced this issue Jan 24, 2024
@pkdash
[#38] updating with develop
513c88e
pkdash added a commit that referenced this issue Jan 24, 2024
@pkdash
[#38] adding requests module to requirements
bf0b427
pkdash added a commit that referenced this issue Jan 24, 2024
@pkdash
[#38] re-generating the schema.json file
807eff1
pkdash added a commit that referenced this issue Jan 24, 2024
@pkdash
[#38] updating tests for the schema changes
a5f0dae
pkdash added a commit that referenced this issue Jan 30, 2024
@pkdash
[#38] moving json schema customization to base class
f5cd531
pkdash added a commit that referenced this issue Jan 31, 2024
@pkdash
[#38] replacing pydantic data type HttpUrl with custom data type Http…
a552324 
…UrlStr
pkdash added a commit that referenced this issue Feb 2, 2024
@pkdash
[#38] latest version of beanie fixes the extra field 'revision_id' issue
337eae2
pkdash added a commit that referenced this issue Feb 2, 2024
@pkdash
[#38] removing duplicate make command
adc37da
pkdash added a commit that referenced this issue Feb 16, 2024
@pkdash
[#38] using custom type HttpUrlStr
e2120ba
pkdash added a commit that referenced this issue Feb 16, 2024
@pkdash
[#38] removing unused function
43896a6
pkdash added a commit that referenced this issue Feb 16, 2024
@pkdash
[#38] upgrading to latest version of FastAPI
798a1b9
@horsburgh
Copy link
Contributor

@pkdash - is this work complete?

@pkdash
Copy link
Collaborator Author

pkdash commented May 14, 2024

@horsburgh No. Lot of code has changed since I last worked on this upgrade. I have to bring this branch up to date with develop and make further code changes to meet Pydantic v2 requirements.

pkdash added a commit that referenced this issue May 29, 2024
@pkdash
[#38] updating with develop and making pydantic v2 specific code changes
18d3608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkdash pkdash

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#38] code migration to use pydantic v2 I-GUIDE/catalog
3 participants
@Maurier @pkdash @horsburgh