feat: implement deletion protection #5626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obai-1
reviewed
Sep 9, 2024
| @@ -65,6 +65,8 @@ const ( | |||
| ResourceStatus = "resource_status" | |||
| //ResourceGroupName ... | |||
| ResourceGroupName = "resource_group_name" | |||
| //DeletionProtection ... | |||
| DeletionProtection = "deletion_protection" | |||
There was a problem hiding this comment.
Terraform has prevent_destroy attribute, documented here.
I wonder if it would be better to use that.
There was a problem hiding this comment.
in theory yes, practically, the issue is that variables can not be used in the lifecycle block: hashicorp/terraform#22544
|
This would resolve my #5534 enhancement request. It would be much easier to control the deletion using a variable, rather than using some weird workaround like this. |
hkantare
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
resolves #5534
This PR adds a generic capability in the provider for resources to opt-in for deletion prevention as it's done by other cloud providers. If the deletion_prevention attribute is true in the state file, deletion is denied. This means we're forcing the following to eventually delete:
For a resource to opt-in for this mechanism, the attribute needs to be declared on the resource: https://github.com/IBM-Cloud/terraform-provider-ibm/pull/5626/files#diff-b40573e3ad8a35e372d9de0636a941c7c901d6120ed862478d72390d3578d6edR811
It seems sensible to support this mechanism for other resources too, COS, VPC, IKS/ROKS come to mind.
Output from acceptance testing: