Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White background behind navigation bar #164

Open
freesuraj opened this issue Jan 2, 2019 · 1 comment
Open

White background behind navigation bar #164

freesuraj opened this issue Jan 2, 2019 · 1 comment

Comments

@freesuraj
Copy link

freesuraj commented Jan 2, 2019

Latest version 1.9 swift 4.2 shows a white background by the navigation bar on a custom presentation that makes it look as if the navigation bar is taller by 100px.
Upon debugging it is revealed that the background is actually a transition passthrough view.

var filterPresenter: Presentr {
        let fullHeight = UIScreen.main.bounds.height
        let maxHeight = min(440, fullHeight)
        let originY = max(0, fullHeight - maxHeight)
        let width = ModalSize.full
        let height = ModalSize.custom(size: Float(maxHeight))
        let center: ModalCenterPosition = .customOrigin(origin: .init(x: 0, y: originY))
        let customType = PresentationType.custom(width: width, height: height, center: center)

        let customPresenter = Presentr(presentationType: customType)
        customPresenter.transitionType = .coverVertical
        customPresenter.dismissTransitionType = .coverVertical
        customPresenter.dismissOnSwipe = false
        return customPresenter
    }

It's being presented using navigation controller like:

var filterVc = xxxx
customPresentViewController(filterPresenter, viewController: NavigationViewController(rootViewController: filterVc), animated: true, completion: nil)

The result looks like this:

image

Any idea?

@dhipin
Copy link

dhipin commented May 2, 2020

I am also having this same issue here when I use my NavigationController as rootviewcontroller. I guess there has been no updates to the repo for the past 2 years.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants