core: Make the CogView.viewport property only readable #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the G_PARAM_CONSTRUCT flag from the CogView.viewport property, because it it supposed to be only readable and it the viewport is set in a separate step separate from view construction by using cog_viewport_add(). It would be technically possible to allow setting the viewport at construction time, but that would need some additional support code it would use G_PARAM_CONSTRUCT_ONLY. For now it is easier to remove the flag.
psaavedra
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
G_PARAM_CONSTRUCTflag from theCogView.viewportproperty, because it it supposed to be only readable and it the viewport is set in a separate step separate from view construction by usingcog_viewport_add(). It would be technically possible to allow setting the viewport at construction time, but that would need some additional support code it would useG_PARAM_CONSTRUCT_ONLY. For now it is easier to remove the flag.