Skip to content

Commit 8124063

Browse files
committed
Fix tests
1 parent 19f77fa commit 8124063

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

insalan/tickets/tests.py

+9-8
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def create_ticket(
3030
token: str,
3131
tourney: Tournament,
3232
ticket_status: Ticket.Status = Ticket.Status.VALID,
33-
) -> None:
33+
) -> int:
3434
"""
3535
Create a ticket for the given username and token.
3636
"""
@@ -42,6 +42,7 @@ def create_ticket(
4242
Ticket.objects.create(
4343
user=user, token=uuid.UUID(token), status=ticket_status, tournament=tourney
4444
)
45+
return user.id
4546

4647

4748
class TicketTestCase(TestCase):
@@ -128,11 +129,11 @@ def test_get(self) -> None:
128129
Test the `get` API endpoint.
129130
"""
130131
tourney = Tournament.objects.all()[0]
131-
create_ticket("user1", "00000000-0000-0000-0000-000000000001", tourney)
132+
user1_id = create_ticket("user1", "00000000-0000-0000-0000-000000000001", tourney)
132133

133134
response = self.client.get(
134135
reverse(
135-
"tickets:get", args=["user1", "00000000-0000-0000-0000-000000000001"]
136+
"tickets:get", args=[user1_id, "00000000-0000-0000-0000-000000000001"]
136137
)
137138
)
138139
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
@@ -141,38 +142,38 @@ def test_get(self) -> None:
141142

142143
response = self.client.get(
143144
reverse(
144-
"tickets:get", args=["user1", "00000000-0000-0000-0000-000000000001"]
145+
"tickets:get", args=[user1_id, "00000000-0000-0000-0000-000000000001"]
145146
)
146147
)
147148
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
148149

149150
self.login("admin")
150151

151152
response = self.client.get(
152-
reverse("tickets:get", args=["user1", "invalid-uuid"])
153+
reverse("tickets:get", args=[user1_id, "invalid-uuid"])
153154
)
154155
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
155156
self.assertEqual(response.json(), {"err": _("UUID invalide")})
156157

157158
response = self.client.get(
158159
reverse(
159-
"tickets:get", args=["user2", "00000000-0000-0000-0000-000000000001"]
160+
"tickets:get", args=[1000, "00000000-0000-0000-0000-000000000001"]
160161
)
161162
)
162163
self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
163164
self.assertEqual(response.json(), {"err": _("Utilisateur⋅ice non trouvé⋅e")})
164165

165166
response = self.client.get(
166167
reverse(
167-
"tickets:get", args=["user1", "00000000-0000-0000-0000-000000000002"]
168+
"tickets:get", args=[user1_id, "00000000-0000-0000-0000-000000000002"]
168169
)
169170
)
170171
self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
171172
self.assertEqual(response.json(), {"err": _("Ticket non trouvé")})
172173

173174
response = self.client.get(
174175
reverse(
175-
"tickets:get", args=["user1", "00000000-0000-0000-0000-000000000001"]
176+
"tickets:get", args=[user1_id, "00000000-0000-0000-0000-000000000001"]
176177
)
177178
)
178179
self.assertEqual(response.status_code, status.HTTP_200_OK)

0 commit comments

Comments
 (0)