improve match's scores validation

Author: istar410

insalan/tournament/models/match.py

@@ -119,7 +119,7 @@ def get_winners_loosers(self) -> List[List[int]]:
         scores = self.get_scores()
 
         for team in self.get_teams_id():
-            if self.bo_type == BestofType.RANKING and scores[team] <= self.get_winning_score():
+            if self.bo_type == BestofType.RANKING and scores[team] > 0 and scores[team] <= self.get_winning_score():
                 winners.append((team,scores[team]))
             elif self.bo_type != BestofType.RANKING and scores[team] >= self.get_winning_score():
                 winners.append((team,scores[team]))

insalan/tournament/models/validators.py

@@ -65,6 +65,10 @@ def tournament_registration_full(tournament: "Tournament", exclude=None):
     return False
 
 def validate_match_data(match: "Match", data):
+    winning_score = match.get_winning_score()
+    winner_count = 0
+    max_score = match.get_max_score()
+
     if match.status != Match.MatchStatus.ONGOING:
         return {
             "status" : "Le match n'est pas en cours"
@@ -81,11 +85,30 @@ def validate_match_data(match: "Match", data):
         }
 
     for _,score in data["score"].items():
-        if score > match.get_max_score():
+        if score > max_score:
             return {
                 "score" : "Le score d'une équipe est trop grand"
             }
 
+        if score < 0:
+            return {
+                "score": "Le score d'une équipe ne peut pas être négatif."
+            }
+
+        if match.bo_type == Match.BestofType.RANKING and score <= winning_score:
+            winner_count += 1
+        elif match.bo_type != Match.BestofType.RANKING and score >= winning_score:
+            winner_count += 1
+    
+    if (
+        (match.bo_type == Match.BestofType.RANKING and winner_count != ceil(match.get_team_count())) 
+        or
+        (match.bo_type != Match.BestofType.RANKING and winner_count != 1)
+    ) :
+        return {
+            "score": "Scores incomplets, il y a trop ou pas assez de gagnants."
+        }
+
     return None
 
 def valid_name(game_param: "game", name: str):