Skip to content

Commit db0d838

Browse files
committed
fix tests
1 parent a143e03 commit db0d838

File tree

5 files changed

+16
-13
lines changed

5 files changed

+16
-13
lines changed

insalan/tournament/models/manager.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from insalan.user.models import User
77

88
from .payement_status import PaymentStatus
9+
from . import validators
910

1011
class Manager(models.Model):
1112
"""
@@ -69,11 +70,11 @@ def clean(self):
6970
"""
7071
user = self.user
7172
event = self.get_team().get_tournament().get_event()
72-
if not unique_event_registration_validator(user,event, manager=self.id):
73+
if not validators.unique_event_registration_validator(user,event, manager=self.id):
7374
raise ValidationError(
7475
_("Utilisateur⋅rice déjà inscrit⋅e dans un tournoi de cet évènement")
7576
)
76-
if not tournament_announced(self.team.get_tournament()):
77+
if not validators.tournament_announced(self.team.get_tournament()):
7778
raise ValidationError(
7879
_("Tournoi non annoncé")
7980
)

insalan/tournament/models/player.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from insalan.user.models import User
88

99
from .payement_status import PaymentStatus
10-
from . import team
10+
from . import team, validators
1111

1212
class Player(models.Model):
1313
"""
@@ -78,15 +78,15 @@ def clean(self):
7878
"""
7979
user = self.user
8080
event = self.team.get_tournament().get_event()
81-
if not unique_event_registration_validator(user,event,player=self.id):
81+
if not validators.unique_event_registration_validator(user,event,player=self.id):
8282
raise ValidationError(
8383
_("Utilisateur⋅rice déjà inscrit⋅e dans un tournoi de cet évènement")
8484
)
85-
if max_players_per_team_reached(self.team, exclude=self.id):
85+
if validators.max_players_per_team_reached(self.team, exclude=self.id):
8686
raise ValidationError(
8787
_("Équipe déjà remplie")
8888
)
89-
if not tournament_announced(self.team.get_tournament()):
89+
if not validators.tournament_announced(self.team.get_tournament()):
9090
raise ValidationError(
9191
_("Tournoi non annoncé")
9292
)

insalan/tournament/models/substitute.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from insalan.user.models import User
99

1010
from .payement_status import PaymentStatus
11+
from . import validators
1112

1213
class Substitute(models.Model):
1314
"""
@@ -83,15 +84,15 @@ def clean(self):
8384
"""
8485
user = self.user
8586
event = self.get_team().get_tournament().get_event()
86-
if not unique_event_registration_validator(user,event, substitute=self.id):
87+
if not validators.unique_event_registration_validator(user,event, substitute=self.id):
8788
raise ValidationError(
8889
_("Utilisateur⋅rice déjà inscrit⋅e dans un tournoi de cet évènement")
8990
)
90-
if max_substitue_per_team_reached(self.team, exclude=self.id):
91+
if validators.max_substitue_per_team_reached(self.team, exclude=self.id):
9192
raise ValidationError(
9293
_("Nombre maximum de remplaçants déjà atteint")
9394
)
94-
if not tournament_announced(self.team.get_tournament()):
95+
if not validators.tournament_announced(self.team.get_tournament()):
9596
raise ValidationError(
9697
_("Tournoi non annoncé")
9798
)

insalan/tournament/models/validators.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
from rest_framework.validators import ValidationError
44

55
# from .event import Event
6-
from . import player
7-
from . import manager
8-
from . import substitute
6+
from . import player as play
7+
from . import manager as manage
8+
from . import substitute as sub
99

1010
def unique_event_registration_validator(user: User, event: "Event", player = None, manager = None, substitute = None):
1111
"""Validate a unique registration per event"""
12-
e_regs = player.Player.objects.filter(team__tournament__event=event,user=user).exclude(id=player).values("id").union(manager.Manager.objects.filter(team__tournament__event=event, user=user).exclude(id=manager).values("id")).union(substitute.Substitute.objects.filter(team__tournament__event=event, user=user).exclude(id=substitute).values("id"))
12+
e_regs = play.Player.objects.filter(team__tournament__event=event,user=user).exclude(id=player).values("id").union(manage.Manager.objects.filter(team__tournament__event=event, user=user).exclude(id=manager).values("id")).union(sub.Substitute.objects.filter(team__tournament__event=event, user=user).exclude(id=substitute).values("id"))
1313
if len(e_regs) > 0:
1414
return False
1515
return True

insalan/tournament/tests.py

+1
Original file line numberDiff line numberDiff line change
@@ -1171,6 +1171,7 @@ def test_example(self):
11711171
"short_name": "TFG",
11721172
"players_per_team": 1,
11731173
"substitute_players_per_team": 0,
1174+
"team_per_match": 2
11741175
},
11751176
"name": "Test Tournament",
11761177
"rules": "have fun!",

0 commit comments

Comments
 (0)