Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle singular matrices #10

Open
JCGoran opened this issue Jul 14, 2022 · 1 comment
Open

Handle singular matrices #10

JCGoran opened this issue Jul 14, 2022 · 1 comment
Assignees
Labels
bug Something isn't working graphics Related to the graphics module tensors Related to the tensors module

Comments

@JCGoran
Copy link
Owner

JCGoran commented Jul 14, 2022

In some cases, such as parameter degeneracy, the Fisher matrix is singular and cannot be inverted; this has an impact on certain methods:

  • FisherMatrix.inverse
  • FisherMatrix.marginalize_over
  • FisherMatrix.correlation_matrix
  • FisherMatrix.constraints
  • FisherBaseFigure.plot
  • plot_curve_1d
  • plot_curve_2d

The code should catch these errors (numpy.LinAlgError), and handle this somehow. Some suggestions (a combination of these would also work):

  • show a UserWarning
  • when calling any plotting methods, plot parallel lines; this is a bit challenging as autoscale_view would make anything else drawn on the axis look tiny, but this can be fixed somehow (see this and this SO questions).
  • something else?
@JCGoran JCGoran added the bug Something isn't working label Jul 14, 2022
@JCGoran JCGoran self-assigned this Jul 14, 2022
@JCGoran JCGoran added graphics Related to the graphics module tensors Related to the tensors module labels Nov 20, 2022
@JCGoran
Copy link
Owner Author

JCGoran commented Apr 6, 2023

Maybe one can use a Moore-Penrose inverse instead of a regular inverse?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working graphics Related to the graphics module tensors Related to the tensors module
Projects
None yet
Development

No branches or pull requests

1 participant