-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify and fix encoding bugs #63
Conversation
Note, the failing test output is sometimes showing the wrong string. That's an as-pect bug, unrelated to this. |
All tests are passing now. Review should be focused on perf impact, if any. |
Running |
Better now. Still room for improvement though. (was -75%, now -8%) |
f272cf2
to
b2de433
Compare
Cloned and tested. Looks good and passes tests. |
FYI, import parsing bug has been submitted separately to as-pect/visitor-as#45 |
There are several cases where escape sequences and numeric exponential notation aren't being handled correctly.
Starting with a draft PR to add some tests, several of which are failing. Will follow up with some fixes to pass the tests, and then we can optimize.