You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@JanMarvin , I did some testing and was able to implement this without having to update any of the tests. I'm pretty sure my poor handling of these is what's wrong with #471 .
This would help with using explicit values (definitely my preference; and we only have to check this once) but also (with another small internal adjustment) allow users to set their default strings value in options().
We could allow zero length vectors (character()) to replace the NULL behavior within write_data2(); which currently errors through txt_to_is(character()). Explicitly setting na.strings = NULL would have the same effect; as would not setting it.
The text was updated successfully, but these errors were encountered:
waiver function for explicit
na.strings
setting@JanMarvin , I did some testing and was able to implement this without having to update any of the tests. I'm pretty sure my poor handling of these is what's wrong with #471 .
This would help with using explicit values (definitely my preference; and we only have to check this once) but also (with another small internal adjustment) allow users to set their default strings value in
options()
.If we would want to use
We could allow zero length vectors (
character())
to replace theNULL
behavior withinwrite_data2()
; which currently errors throughtxt_to_is(character())
. Explicitly settingna.strings = NULL
would have the same effect; as would not setting it.The text was updated successfully, but these errors were encountered: