Examples of using DocumentListener with OpenTelemetry #3667
Conversation
STRUDSO
commented
Feb 11, 2025
STRUDSO
commented
- CorrelationListener
- Events listener
- CorrelationListener - Events listener
- Use TraceId as i think this more closely aligns with terminology in otel trace_id. I think rootid is based on the old Activity pre w3cformat and is in my understanding equal to traceid given the idformat is ActivityIdFormat.W3C (which is default since .net 5) - Not sure I understand why we would take the id ie, traceparent of the parent span instead of the id (traceparent) of the current activity? If i were to start a trace based of what i loaded from the db, I would use activitycontext.parse(doc.CausationId) and in that case i don't see why it would be 1 level up.
|
@STRUDSO Can you start by explaining why all of Marten's existing Otel support doesn't cover whatever you want here? |
|
Let me spend a little more time with this, and yes some of it probably belongs in Samples. At first i didn't realize the work in: marten/src/Marten/ISessionFactory.cs Line 46 in a0b339a Spent some time on understanding traceparent, trace_id and parent_id in the context of this: In SessionFactoryBase it has: documentSession.CorrelationId = Activity.Current?.RootId;RootId = TraceId in my understanding, so all good, don't know anything about tracing pre opentelemetry, so maybe this is how it should be. But seems like opentelemetry calls it traceid. i guess this is what you would use to find "all" of the spans in jaeger eg. documentSession.CausationId = Activity.Current?.ParentId;ParentId i don't fully understand, my understanding is: using var activity1 = source.Start
using var activity2 = source.Start
// activity2.ParentId == activity.Id
using var session = store.OpenSession()
session.Store(doc)then doc.CausationId would point to the Id of activity1. |
