Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Websocket library #236

Open
fortuna opened this issue May 7, 2024 · 3 comments
Open

Replace Websocket library #236

fortuna opened this issue May 7, 2024 · 3 comments

Comments

@fortuna
Copy link
Contributor

fortuna commented May 7, 2024

We are using https://pkg.go.dev/golang.org/x/net/websocket, which is poorly maintained.

Better options are:

Ideally we would be able to support Websockets over h2 and even h3, for multiplexing and better performance.

However, it's not clear any implementation can support it yet, given limitations in the http2 support in Go:

@fortuna fortuna added this to the Add Websockets Support milestone May 7, 2024
@fortuna
Copy link
Contributor Author

fortuna commented May 7, 2024

Oh, neither of the libraries support h2 :-/

@fortuna
Copy link
Contributor Author

fortuna commented May 7, 2024

We can consider adding h3 support with quic-go: https://quic-go.net/docs/webtransport/

@liudongmiao
Copy link

We can consider adding h3 support with quic-go: https://quic-go.net/docs/webtransport/

There are RFC 9220, websocket over http/3.

I have implemented in nginx, make nginx support proxy http2/http3 websocket to websocket 1.1 backend. And even make a simple client to use, as a sip003 plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants