Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new integration tests. No new release. #1080

Merged
merged 31 commits into from
Jan 16, 2024
Merged

Test new integration tests. No new release. #1080

merged 31 commits into from
Jan 16, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jan 12, 2024

This follows up #1079 which did not actual trigger integration tests because the source of the PR was not dev.

This PR still needs:

@ablaom ablaom marked this pull request as draft January 12, 2024 06:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b6303d) 57.89% compared to head (848d415) 57.89%.
Report is 21 commits behind head on master.

❗ Current head 848d415 differs from pull request most recent head 7358186. Consider uploading reports for the commit 7358186 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1080   +/-   ##
=======================================
  Coverage   57.89%   57.89%           
=======================================
  Files           2        2           
  Lines          38       38           
=======================================
  Hits           22       22           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom
Copy link
Member Author

ablaom commented Jan 12, 2024

Okay, my attempt here in ci.yml to change the MLJ_TEST_INTEGRATION flag for a PR with dev as source does not seem to have worked (julia 1 test is on 6mins, we are expected ~60min).

@DilumAluthge Are you able to look over my ci.yml logic? This is not a strong point of mine.

@DilumAluthge
Copy link
Member

Let me take a closer look. Something seems to not be working.

@DilumAluthge
Copy link
Member

#1081

…roject

Move EvoLinear into [extras] where it belongs
@ablaom
Copy link
Member Author

ablaom commented Jan 14, 2024

Well, this is weird:

Screen Shot 2024-01-15 at 8 41 38 AM

@DilumAluthge
Copy link
Member

There are two jobs: push and pull_request. The screenshot you posted is from a push job, in which the various PR-related variables won't be defined. Those variables will be defined in the pull_request job.

@ablaom
Copy link
Member Author

ablaom commented Jan 14, 2024

Go it! Yay, it's working!!

Thanks @DilumAluthge ❤️

@ablaom ablaom marked this pull request as ready for review January 14, 2024 22:01
@ablaom
Copy link
Member Author

ablaom commented Jan 16, 2024

Hooray 🎉 . MLJ integration tests are now, well... integrated.

@ablaom ablaom merged commit 4d755b7 into master Jan 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants