-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test new integration tests. No new release. #1080
Conversation
Add integration tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1080 +/- ##
=======================================
Coverage 57.89% 57.89%
=======================================
Files 2 2
Lines 38 38
=======================================
Hits 22 22
Misses 16 16 ☔ View full report in Codecov by Sentry. |
Okay, my attempt here in ci.yml to change the @DilumAluthge Are you able to look over my ci.yml logic? This is not a strong point of mine. |
Co-authored-by: Dilum Aluthge <[email protected]>
Let me take a closer look. Something seems to not be working. |
…roject Move EvoLinear into [extras] where it belongs
There are two jobs: push and pull_request. The screenshot you posted is from a push job, in which the various PR-related variables won't be defined. Those variables will be defined in the pull_request job. |
Go it! Yay, it's working!! Thanks @DilumAluthge ❤️ |
Hooray 🎉 . MLJ integration tests are now, well... integrated. |
This follows up #1079 which did not actual trigger integration tests because the source of the PR was not
dev
.This PR still needs: