Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include abstract to the dataframe #40

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

roflmaostc
Copy link
Contributor

I guess non-breaking if we assume the dataframe was internal.

julia> JuliaCon.talksabout("wave")

Wednesday 10 July 2024, 10:50 in If (1.1)
        MIToS Evolution: Riding the Bioinformatics Wave (Lightning Talk)
        ├─ Diego Javier Zea
        ├─ https://pretalx.com/juliacon2024/talk/RM9TMC/
        └─ Biology & Life Sciences

Friday 12 July 2024, 16:24 in Function (4.1)
        SeismicWaves.jl: a wave simulation package for FWI on multi-xPUs (Talk)
        ├─ Giacomo Aloisi
        ├─ https://pretalx.com/juliacon2024/talk/TGQYQX/
        └─ Julia for High-Performance Computing

Friday 12 July 2024, 16:00 in For Loop (3.2)
        Wave and Ray Optics for Light Based Tomographic 3D printing (Talk)
        ├─ Felix Wechsler
        ├─ https://pretalx.com/juliacon2024/talk/WEXWEJ/
        └─ Physics & Quantum Chemistry

Friday 12 July 2024, 14:30 in While Loop (4.2)
        High Resolution Flux Estimation with TurbulenceFlux.jl (Lightning Talk)
        ├─ Gabriel Destouet
        ├─ https://pretalx.com/juliacon2024/talk/7LAYTN/
        └─ Earth and climate science in Julia: Power to the user

(Shown times are in the following time zone: Europe/Berlin)

julia> JuliaCon.talksabout("wave"; search_abstract=false)

Wednesday 10 July 2024, 10:50 in If (1.1)
        MIToS Evolution: Riding the Bioinformatics Wave (Lightning Talk)
        ├─ Diego Javier Zea
        ├─ https://pretalx.com/juliacon2024/talk/RM9TMC/
        └─ Biology & Life Sciences

Friday 12 July 2024, 16:24 in Function (4.1)
        SeismicWaves.jl: a wave simulation package for FWI on multi-xPUs (Talk)
        ├─ Giacomo Aloisi
        ├─ https://pretalx.com/juliacon2024/talk/TGQYQX/
        └─ Julia for High-Performance Computing

Friday 12 July 2024, 16:00 in For Loop (3.2)
        Wave and Ray Optics for Light Based Tomographic 3D printing (Talk)
        ├─ Felix Wechsler
        ├─ https://pretalx.com/juliacon2024/talk/WEXWEJ/
        └─ Physics & Quantum Chemistry

(Shown times are in the following time zone: Europe/Berlin)

@carstenbauer
Copy link
Member

The dataframe is certinaly internal. But, yeah, we should really mark the public API (the functions explicitly mentioned in README.md) by public, maybe even export some of them.

(With https://github.com/carstenbauer/SysInfo.jl/blob/main/src/utils.jl this can be done in a backwards compatible way.)

@carstenbauer
Copy link
Member

Can you add a test (even if it just tests that the function exists and takes in a string)?

@roflmaostc
Copy link
Contributor Author

Should I copy paste this into JuliaCon?

@carstenbauer
Copy link
Member

Should I copy paste this into JuliaCon?

Sure, but I think this should be separate PR (after this one).

@carstenbauer
Copy link
Member

Minor thing: search_abstract should probably better be a keyword argument. Otherwise, this looks good to me!

@roflmaostc
Copy link
Contributor Author

Isn't it one?

@carstenbauer
Copy link
Member

@carstenbauer carstenbauer merged commit 444c16e into JuliaCon:master Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants