Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dispatch errors in tests on Julia 1.10 #3342

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jun 15, 2023

This is a minor test fix.

@LilithHafner - there are currently a lot of failing tests on Julia nightly due to sorting changes following #3340.
I understand that soon they would be gone, right? (when your PR to Julia is merged).
I will wait to merge this PR until then.

@bkamins bkamins added the ecosystem Issues in DataFrames.jl ecosystem label Jun 15, 2023
@bkamins bkamins added this to the 1.6 milestone Jun 15, 2023
@bkamins bkamins closed this Jun 18, 2023
@bkamins bkamins reopened this Jun 18, 2023
@bkamins bkamins merged commit 82f4db0 into main Jun 19, 2023
6 of 7 checks passed
@bkamins bkamins deleted the bk/fix_dispatch_errors_julia_1_10 branch June 19, 2023 20:38
@bkamins
Copy link
Member Author

bkamins commented Jun 19, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem Issues in DataFrames.jl ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants