Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: add new compat entry for Statistics at version 1, (keep existing compat) #3465

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request sets the compat entry for the Statistics package to 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-09-16-00-04-29-247-03274842355 branch from f2cd906 to 7636171 Compare September 16, 2024 00:04
@bkamins bkamins added this to the 1.7 milestone Sep 16, 2024
@bkamins
Copy link
Member

bkamins commented Sep 16, 2024

@nalimilan - I understand adding this requirement is OK even for Julia 1.6 (it should not break it - right?). Thank you!

@bkamins bkamins added the ecosystem Issues in DataFrames.jl ecosystem label Sep 16, 2024
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think it should be OK.

@bkamins bkamins merged commit ef37096 into main Sep 19, 2024
@bkamins bkamins deleted the compathelper/new_version/2024-09-16-00-04-29-247-03274842355 branch September 19, 2024 06:34
@bkamins
Copy link
Member

bkamins commented Sep 19, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem Issues in DataFrames.jl ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants