-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird error when loading DifferentiableFrankWolfe extension #121
Comments
That's because DifferentiableFrankWolfe v0.3, which uses a new version of ImplicitDifferentiation (switching from AbstractDifferentiation to DifferentiationInterface) was ready but not released. I triggered registration, once it's done InferOpt is due for a compat bump |
I tried updating to DifferentiableFrankWolfe v0.3. InferOpt.jl/ext/InferOptFrankWolfeExt.jl Line 47 in 9419111
Same for LinearMinimizationOracle from FrankWolfe.jl.
|
The default solver for ImplicitDifferentiation.jl is now called |
Should we then add FrankWolfe and ImplicitDifferentiation as (weak)dependencies, how does this work? |
Just make a list of packages in the extensions section of the Project instead of a single name.
A bit more cumbersome for users, but hey, there are no users |
Ok, I tried to update all this, I have an issue in the paths tests. |
Yes, the new version of ImplicitDifferentiation only accepts vectors, since higher-order tensors are flattened into vectors anyway. So we need a manual resize on the InferOpt side |
There is a weird error when loading the DifferentiableFrankWolfeExt, that does not seem to affect InferOpt other than displaying an error message.
To reproduce:
outputs the following error:
then the extension seems to still work, at least tests still succeed.
It seems the extension of a downstream package (
ImplicitDifferentiationForwardDiffExt
) fails but does not directly affect InferOpt, although it displays a terrifying error message.Seems related to the interaction between ImplicitDifferentiation and the new AbstractDifferentiation.
There is also a similar error (from
ImplicitDifferentiationZygoteExt
) when loading Zygote afterwards.@gdalle do you have any insights ?
The text was updated successfully, but these errors were encountered: