Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS GitHub Actions CI stuck on adding AMDGPU.jl #614

Open
williamfgc opened this issue Apr 4, 2024 · 2 comments
Open

macOS GitHub Actions CI stuck on adding AMDGPU.jl #614

williamfgc opened this issue Apr 4, 2024 · 2 comments

Comments

@williamfgc
Copy link

williamfgc commented Apr 4, 2024

Mostly asking for guidance and to know if this is a known issue.

Our macOS CI on GitHub Actions runners shows a spurious behavior getting stuck on AMDGPU.jl fairly frequently see this log and other recent failure log.

Is there anything that could explain this behavior on the packaging side? Thanks in advance!

@luraess
Copy link
Collaborator

luraess commented Apr 4, 2024

Why would you add AMDGPU on macOS? Can't you run AMDGPU backend tests only on Linux targets? Sorry if I am missing something.

@williamfgc
Copy link
Author

williamfgc commented Apr 4, 2024

@luraess I just went with the assumption that GPU back ends are lightweight packages (not different from adding CUDA.jl to a non-NVIDIA GPU system from their docs on Conditional Use). Because CUDA.jl always loads, even if the user doesn't have a GPU or CUDA, you should just depend on it like any other package (and not use, e.g., Requires.jl). The strange thing is that this works sometimes and sometimes doesn't with AMDGPU.jl, it always works with CUDA.jl on our CI. I just wanted to know if this is known.

Weak dependencies don't propagate to tests and I must admit I don't know of a "best practice" to put these two together and I'd glad to listen to options.

From the docs here it seems a separate test/Project.toml still TBD:

The exact interaction between Project.toml, test/Project.toml and their corresponding Manifest.tomls are not fully worked out and may be subject to change in future versions. The older method of adding test-specific dependencies, described in the previous section, will therefore be supported throughout all Julia 1.X releases.

Also, this discussion might be related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants