Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for LinearAlgebra.kron #422

Closed
ytdHuang opened this issue Sep 19, 2024 · 2 comments
Closed

Support for LinearAlgebra.kron #422

ytdHuang opened this issue Sep 19, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ytdHuang
Copy link

Would it also be possible to support kron for MtlArray (just like CUDA.jl) ?

The current kron for MtlArray uses scalar indexing.

I think we also need the methods for applying kron to Transpose{T,<:MtlArray} and Adjoint{T,<:MtlArray}.
@maleadt maleadt added enhancement New feature or request good first issue Good for newcomers labels Sep 19, 2024
@maleadt
Copy link
Member

maleadt commented Sep 19, 2024

Should be easy enough to port, as the CUDA.jl implementation only relies on repeat from GPUArrays.

However, if anybody would want to work on this, I'd advise against just copying the code here, but instead moving the existing CUDA kron implementation to GPUArrays.

@ytdHuang ytdHuang mentioned this issue Sep 19, 2024
Open
@ytdHuang
Copy link
Author

okay, I re-make a new PR, let's discuss in GPUArrays.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maleadt @ytdHuang