Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen -> MakieScreen (abstract type) #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asinghvi17
Copy link

No description provided.

@barche
Copy link
Collaborator

barche commented Feb 20, 2024

Is this all it takes to support the latest Makie? If so, that would be great news :)

@marcom
Copy link

marcom commented May 23, 2024

I tried this patch, and the tests for QML.jl pass.

Unfortunately, the Makie examples from https://github.com/barche/QmlJuliaExamples don't seem to work. I tried opengl/makie.jl and opengl/makie-plot.jl, both failed with this error message:

MethodError: no method matching GLMakie.GLAbstraction.ShaderCache()

Closest candidates are:
  GLMakie.GLAbstraction.ShaderCache(::Any, ::Dict{String, Vector{String}}, ::Dict{String, Dict{Any, GLMakie.GLAbstraction.Shader}}, ::Dict{Any, GLMakie.GLAbstraction.GLProgram})
   @ GLMakie ~/.julia/packages/GLMakie/Wvj4h/src/GLAbstraction/GLShader.jl:90
  GLMakie.GLAbstraction.ShaderCache(::Any, ::Any, ::Any, ::Any)
   @ GLMakie ~/.julia/packages/GLMakie/Wvj4h/src/GLAbstraction/GLShader.jl:90
  GLMakie.GLAbstraction.ShaderCache(::Any)
   @ GLMakie ~/.julia/packages/GLMakie/Wvj4h/src/GLAbstraction/GLShader.jl:97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants