Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TLeafS #161

Merged
merged 1 commit into from
Apr 7, 2022
Merged

add TLeafS #161

merged 1 commit into from
Apr 7, 2022

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Apr 7, 2022

partially fix #160

@tamasgal
Copy link
Member

tamasgal commented Apr 7, 2022

Ah that was quick 😆 I was already looking. Now I am investigating this TBasket thing...

@Moelf
Copy link
Member Author

Moelf commented Apr 7, 2022

yeah as shown in the other thread, we can already unpack it and we should. except I don't know what's the relationship between that basket to the branch user wants to read

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #161 (86d26f3) into master (110fd94) will decrease coverage by 0.65%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   91.18%   90.53%   -0.66%     
==========================================
  Files          11       11              
  Lines        1531     1542      +11     
==========================================
  Hits         1396     1396              
- Misses        135      146      +11     
Impacted Files Coverage Δ
src/bootstrap.jl 90.34% <0.00%> (-2.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 110fd94...86d26f3. Read the comment docs.

@Moelf Moelf merged commit 493a3c9 into JuliaHEP:master Apr 7, 2022
@Moelf Moelf deleted the tleafs branch April 7, 2022 15:46
@Moelf Moelf added the need test label Apr 7, 2022
Moelf added a commit to Moelf/UnROOT.jl that referenced this pull request Jun 23, 2022
Moelf added a commit to aminnj/UnROOT.jl that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LazyTree construction errors : UndefVarError: TLeafS / UndefVarError: TBasket not defined
2 participants