Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semi-dynamic ccall support #69

Open
topolarity opened this issue Jan 30, 2024 · 1 comment
Open

Add semi-dynamic ccall support #69

topolarity opened this issue Jan 30, 2024 · 1 comment

Comments

@topolarity
Copy link
Member

          I relaxed this test and marked the original as broken

We need to expand our resolution here to walk through the PhiNode in the LLVM IR and notice the ccall / jl_load_and_lookup machinery.

Originally posted by @topolarity in #68 (comment)

@topolarity
Copy link
Member Author

This is not a soundness bug, but it does mean that some dynamic ccalls that we could statically resolve to the runtime are instead treated as DynamicDispatch

topolarity added a commit that referenced this issue Oct 8, 2024
These can occasionally happen due to known incomplete spots in our call
resolution (#69) or due
to changes in the optimizer, etc.

Rather than conservatively calling these "dynamic dispatches", this adds
a new error type that encourages the user to file a bug upstream, since a
feature-complete AllocCheck should never encounter them.
topolarity added a commit that referenced this issue Oct 8, 2024
These can occasionally happen due to known incomplete spots in our call
resolution (#69) or due
to changes in the optimizer, etc.

Rather than conservatively calling these "dynamic dispatches", this adds
a new error type that encourages the user to file a bug upstream, since a
feature-complete AllocCheck should never encounter them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant