Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is running with threads? #57415

Open
vtjnash opened this issue Feb 14, 2025 · 9 comments
Open

CI is running with threads? #57415

vtjnash opened this issue Feb 14, 2025 · 9 comments
Labels
ci Continuous integration multithreading Base.Threads and related functionality

Comments

@vtjnash
Copy link
Member

vtjnash commented Feb 14, 2025

Taking a look at a CI crash, I noticed it was initializing an extra thread, which isn't really supported by our testsuite, and so may be causing the recent crashes. I don't know how this computation suddenly got corrupted:

$ ./julia -E 'Threads.maxthreadid()'
2
@oscardssmith
Copy link
Member

Is this that we are now defaulting to 1 regular and 1 interactive thread?

@vtjnash
Copy link
Member Author

vtjnash commented Feb 14, 2025

Are we? That sounds like a bug

@DilumAluthge
Copy link
Member

I believe it is intentional behavior: #57087

@vtjnash
Copy link
Member Author

vtjnash commented Feb 14, 2025

Do we need to revert that entirely or just some part of it?

@nsajko nsajko added multithreading Base.Threads and related functionality ci Continuous integration labels Feb 14, 2025
@DilumAluthge
Copy link
Member

Can we instead fix our test suite to work correctly in the case of 1 regular thread, 1 interactive thread?

@oscardssmith
Copy link
Member

Agreed with Dilum. Julia has multithreading as a core feature. If it's broken, we need to fix the bugs.

@IanButterworth
Copy link
Member

and so may be causing the recent crashes

Specifics would help here.

@IanButterworth
Copy link
Member

Also, the approach in #57087 was to not special-case tests, but to make them robust to threading state.

I'm aware of one open flaky issue #57198

@DilumAluthge
Copy link
Member

Also, for the test suite, we probably don't need to support the full general case. It might be sufficient to only support the following two special cases:

  • 1 regular thread, 0 interactive threads.
  • 1 regular thread, 1 interactive thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration multithreading Base.Threads and related functionality
Projects
None yet
Development

No branches or pull requests

5 participants