Intersect: try normal+reverse+existential subtyping during intersection #57476
+118
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
added
types and dispatch
fix JuliaLang#57429 JuliaLang#41561 Typevars are all existential (in the sense of variable lb/ub) during intersection. This fix is somehow costly as we have to perform 3 times check to prove a false result. But a single existential <: seems too dangerous as it cause many circular env in the past.
would it make sense to include an example snippet benchmarking this cost? even if it is a regression it could be tracked for later improvement |
|
I tried some packages, e.g. julia> @time using DifferentialEquations
10.825558 seconds (19.42 M allocations: 1.040 GiB, 9.68% gc time, 6.35% compilation time) # before
10.814457 seconds (19.40 M allocations: 1005.084 MiB, 6.78% gc time, 4.93% compilation time) # afterThe influence seems negligible here, but not sure if it's representative. |
|
@nanosoldier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typevars are all existential (in the sense of variable lb/ub) during intersection. This fix is somehow costly as we have to perform 3 times check to prove a false result. But a single existential <: seems too dangerous as it cause many circular env in the past.
fix #57429
fix #41561