Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3x regression in broadcast with fused outer constructor #57434

Open
adienes opened this issue Feb 17, 2025 · 0 comments · May be fixed by #57442
Open

3x regression in broadcast with fused outer constructor #57434

adienes opened this issue Feb 17, 2025 · 0 comments · May be fixed by #57442
Labels
broadcast Applying a function over a collection performance Must go faster regression 1.10 Regression in the 1.10 release

Comments

@adienes
Copy link
Contributor

adienes commented Feb 17, 2025

julia> using BenchmarkTools

julia> a, b = [0.1,0.2], [1.0,2.0];

julia> bar2(T, c, f) = sum(f .* T.(c));

julia> @btime bar2(Float32, $a, $b)

# 337.484 ns (6 allocations: 208 bytes) # 1.9
# 1.008 μs (10 allocations: 432 bytes) # 1.10
# 1.100 μs (11 allocations: 432 bytes) #nightly 1.13

found while looking at #39151

I suspect this has also regressed more than once in small increments, but I focused my bisection to the increase in allocations (which was also a 3x in time), which pointed at #49725

@adienes adienes added performance Must go faster regression 1.10 Regression in the 1.10 release labels Feb 17, 2025
@adienes adienes changed the title regression in sum with broadcast outer constructor 3x regression in sum with broadcast outer constructor Feb 17, 2025
@adienes adienes changed the title 3x regression in sum with broadcast outer constructor 3x regression in broadcast with fused outer constructor Feb 17, 2025
@adienes adienes added the broadcast Applying a function over a collection label Feb 17, 2025
@adienes adienes linked a pull request Feb 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Applying a function over a collection performance Must go faster regression 1.10 Regression in the 1.10 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant