only cache concrete types #57442
Open
only cache concrete types #57442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Feb 17, 2025
|
awesome, thanks for the fast review do you have any suggestions for a good test? I could do something like but I'm worried this is too high-level (it technically depends on broadcast implementation as well) |
|
failure is legit and comes from although maybe this is expected? since |
vtjnash
reviewed
Feb 17, 2025
| } | ||
| else { | ||
| jl_datatype_t *dtuw = (jl_datatype_t*)uw; | ||
| if (!dtuw->isconcretetype || dtuw->name->wrapper != p) |
There was a problem hiding this comment.
Suggested change
| if (!dtuw->isconcretetype || dtuw->name->wrapper != p) | |
| if (!dtuw->isconcretetype && dtuw->name->wrapper != p) |
There was a problem hiding this comment.
this change appears to reintroduce the performance problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe too many types are being constructed (causing allocations) when nonconcrete hash entries collide with the desired concrete type
appears to fix #57434 (at least back to
<=1.9performance)I will admit I am not 100% sure I understand why this works, nor am I sure what the best way to add a test is besides add this example as a benchmark.