Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnknownMass called with bad argument #132

Open
cscherrer opened this issue Sep 1, 2023 · 1 comment
Open

UnknownMass called with bad argument #132

cscherrer opened this issue Sep 1, 2023 · 1 comment
Assignees

Comments

@cscherrer
Copy link
Collaborator

cscherrer commented Sep 1, 2023

Currently (v0.14.7) we have

massof(m::AbstractMeasure) = UnknownMass(m)

But there's no such method:

julia> methods(MeasureBase.UnknownMass)
# 4 methods for type constructor:
 [1] MeasureBase.UnknownMass()
     @ ~/git/MeasureBase.jl/src/mass-interface.jl:19
 [2] (::Type{T})(x::AbstractChar) where T<:Union{AbstractChar, Number}
     @ Base char.jl:50
 [3] (::Type{T})(x::T) where T<:Number
     @ Core boot.jl:792
 [4] (::Type{T})(x::Base.TwicePrecision) where T<:Number
     @ Base twiceprecision.jl:266

I think this should be

massof(m::AbstractMeasure) = UnknownMass()
@cscherrer cscherrer self-assigned this Sep 1, 2023
@cscherrer
Copy link
Collaborator Author

Oh good, looks like this is already fixed by #120

@cscherrer cscherrer linked a pull request Sep 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant