Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exponential of Semicircle Window #73

Open
tknopp opened this issue Jan 27, 2022 · 1 comment
Open

Add Exponential of Semicircle Window #73

tknopp opened this issue Jan 27, 2022 · 1 comment
Labels
feature good first issue Indicates a good issue for first time contributors

Comments

@tknopp
Copy link
Member

tknopp commented Jan 27, 2022

We want to integrate the "exponential of semicircle" window proposed in this paper: https://arxiv.org/abs/1808.06736
I am not completely sure but my FINUFFT wrapper indicates that it is slightly more accurate than Kaiser-Bessel.

Remarks:

This would be a nice "good first time contributor" project if somebody want to have look at it. Otherwise I will five it a go when time permits.

@tknopp tknopp added good first issue Indicates a good issue for first time contributors feature labels Jan 27, 2022
@tknopp
Copy link
Member Author

tknopp commented Feb 28, 2022

Apparently, I was wrong, which is actually a good thing. Kaiser bessel is still more accurate than the semicircle window and it has an analytical Fourier transform. So the motivation to implement this is now more of an academic nature to make accuracy comparisons. The evaluation time for the window does not really matter since the polynomial approximation of the window that we use in the new precompute option is accurate and very fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Indicates a good issue for first time contributors
Projects
None yet
Development

No branches or pull requests

1 participant