Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Formatting.jl #37

Merged

Conversation

nickrobinson251
Copy link
Contributor

@nickrobinson251 nickrobinson251 commented Mar 6, 2024

Formatting.jl is no longer recently added a rather ugly and annoying deprecation warning that makes it clear it does not want to be used.

 Formatting
│  ┌ Warning: DEPRECATION NOTICE
│  │
│  │ Formatting.jl has been unmaintained for a while, with some serious
│  │ correctness bugs compromising the original purpose of the package. As a result,
│  │ it has been deprecated - consider using an alternative, such as
│  │ `Format.jl` (https://github.com/JuliaString/Format.jl) or the `Printf` stdlib directly.
│  │
│  │ If you are not using Formatting.jl as a direct dependency, please consider
│  │ opening an issue on any packages you are using that do use it as a dependency.
│  │ From Julia 1.9 onwards, you can query `]why Formatting` to figure out which
│  │ package originally brings it in as a dependency.
│  └ @ Formatting ~/packages/Formatting/3VxOt/src/Formatting.jl:12

Here i just copy-pasted in the one feature of it that seems to be used https://github.com/JuliaIO/Formatting.jl/blob/0db1b043dfe6f0a2678cb48813b49565c2ef89f9/src/cformat.jl#L77-L93
The function could be more efficient, but i just wanted to do the most like-for-like change in this PR.

an alternative would be to switch to Format.jl but the dependency hardly seems worth it.

@nickrobinson251
Copy link
Contributor Author

cc @NHDaly do you have merge rights here? can you review please?

src/LinuxPerf.jl Outdated Show resolved Hide resolved
Copy link
Member

@carstenbauer carstenbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. My comments are only minor. If you say that you don't want to / don't have time to address them I would be fine with merging as is.

src/LinuxPerf.jl Show resolved Hide resolved
src/LinuxPerf.jl Show resolved Hide resolved
@carstenbauer carstenbauer merged commit f04fff2 into JuliaPerf:master Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants