Problems with conversion of Unsigned to RGB

[mateuszbaran]

I've accidentally been using Base.convert method from this package that converts Unsigned to RGB. This is type-unstable (which is easy to fix) but it also looks like type piracy, so this method likely shouldn't even be in this package. Here is that method:

PlotUtils.jl/src/color_utils.jl

Lines 96 to 99 in 44e45ec

	function Base.convert(::Type{RGB}, h::Unsigned)
	mask = 0x0000FF
	RGB([(x & mask) / 0xFF for x in (h >> 16, h >> 8, h)]...)
	end

. What do you think should be done about it?

[t-bltg]

@BeastyBlacksmith, do you know why this is exposed in Base ?

[BeastyBlacksmith]

This predates my time quite a bit. But I agree, that this is type piracy and we should get rid of it.
One just has to be careful with this, since it is unclear where this is used. It might not only affect Plots, if we remove it.

[t-bltg]

This predates my time quite a bit. But I agree, that this is type piracy and we should get rid of it.
One just has to be careful with this, since it is unclear where this is used. It might not only affect Plots, if we remove it.

Thanks.

@mateuszbaran you can make a PR changing this to an internal method, but you'll have to run Plots.jl test suite, checking that this does not break anything.
Someone should also investigate where this method is used in the JuliaPlots ecosystem, to find potential breaks.

[BeastyBlacksmith]

Here is a list of all dependents: https://juliahub.com/ui/Packages/PlotUtils/YveHG/1.0.11?t=2

[mateuszbaran]

That's quite a lot of dependent packages. I could check if removing it breaks Plots.jl but going through all of these packages is a bit too much 😅 .