Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement: Replace all applicable UDFs with PDFs #600

Open
ConstrainedRandomVar opened this issue Dec 8, 2021 · 1 comment

Comments

@ConstrainedRandomVar
Copy link
Collaborator

The factory default rules still seem to have extensive usage of UDFs through Python functions. These should be converted to corresponding PDFs wherever supported.

  • All decimal conversions, division, subtraction, math functions should be converted to eval
  • String concatenation can also be done through concatenate
  • Rate of change calculation can be handled through rate-of-change
  • Value difference calculation can be handle through value-difference

For example:

  • chassis.power/check-pem-power-usage: used_percentage.py
  • kernel.ifstate/check-too-many-dead-ifstates: get-dead-alive-ratio.py
    ...
@vvikramb
Copy link
Collaborator

vvikramb commented Feb 7, 2022

Eval function has replaced the UDF's wherever possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants