Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

slicker sometimes uses wrongly uses full-names inside comments #33

Open
csilvers opened this issue Jul 13, 2018 · 0 comments
Open

slicker sometimes uses wrongly uses full-names inside comments #33

csilvers opened this issue Jul 13, 2018 · 0 comments

Comments

@csilvers
Copy link
Member

I had code like this:

CONST = False

def foo():
    """Do something whenever CONST is True."""

I then moved both CONST and foo() to a new file via slicker.py file.CONST file.foo newfile.py and the docstring then said: """Do something whenever newfile.CONST is True."""

This isn't wrong per se, but it should be saying "Do something whenever CONST is True."

To reproduce in webapp, checkout d8e31c746e and then run:
../slicker/slicker.py content_render.video_handlers.{TALK_TO_BIGQUERY,_FIELD_NAMES,get_translation_table,get_translation_table_csv} content/videos/translation_table.py
The docstring in get_translation_table() will say "Note: if content.videos.translation_table.TALK_TO_BIGQUERY is false ..."

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant