Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Extensions: Volume should be independent #559

Closed
echadwick-artist opened this issue Jul 19, 2024 · 1 comment
Closed

Disable Extensions: Volume should be independent #559

echadwick-artist opened this issue Jul 19, 2024 · 1 comment

Comments

@echadwick-artist
Copy link
Contributor

The disable control for Volume should be independent of Transmission and Diffuse Transmission, because it can interact with other extensions like Dispersion (and potentially other future extensions which interact with Volume).

In the Advanced Controls tab, if all extensions are disabled except KHR_materials_transmission, KHR_materials_volume, and KHR_materials_dispersion, and subsequently KHR_materials_transmission is disabled, then KHR_materials_volume is automatically disabled. This prevents Dispersion from using Volume. The same behavior occurs with KHR_materials_diffuse_transmission.

@emackey
Copy link
Member

emackey commented Jul 25, 2024

Volume & Dispersion can't have a visual effect without either transmission or diffuse transmission, which is why the logic was put there in the first place. Without one of those two, light cannot penetrate the surface, so the volumetric and dispersion properties don't make any difference. But, perhaps this bit of UI logic is overkill here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants