Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weka PLS for classification does not work #64

Open
gdrakakis opened this issue Jun 10, 2016 · 1 comment
Open

Weka PLS for classification does not work #64

gdrakakis opened this issue Jun 10, 2016 · 1 comment
Assignees
Milestone

Comments

@gdrakakis
Copy link

Eternally Queued

@hampos
Copy link
Member

hampos commented Jul 6, 2016

@gdrakakis : The task is not eternally queued, it is progressing and then going to Error state but the UI is not refreshing.

@AValsamis : This is a problem for all weka algorithms that support classification. There are 2 things that need fixing to resolve this.

  1. The code that converts a Dataset to Weka Instances goes like this:
    instance.setValue(data.attribute(entry.getKey()), Double.parseDouble(entry.getValue().toString()));
    It tries to ignore the value's type and parse it to Double. This obviously will not work for classification.
    You can find it here: https://github.com/KinkyDesign/JaqpotQuattro/blob/development/JaqpotAlgorithmServices/src/main/java/org/jaqpot/algorithm/weka/InstanceUtils.java#L72
  2. Each algorithm that supports either Regression or Classification must be registered 2 times with different algorithm ids. This will give us the ability to modify it's parameters and in the 1st case allow only parameters that are valid for Regression, and on the 2nd case parameters valid for Classification.
    For example, LibSVM algorithm's type parameter can take either of those values:
    NU_SVR, EPSILON_SVR
    NU_SVC, C_SVC, ONE_CLASS_SVM
    The first 2 will try to do Regression, while the other 3 will do Classification.
    So, weka-svm-regression will have allowedValues the first 2 on type parameter, while weka-svm-classification will have the other 3.

For now I will remove weka-pls from classification.

@hampos hampos modified the milestones: 4.0.3 Release, 4.0.2 Release Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants