Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use most recent grape functions #99

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update to use most recent grape functions #99

wants to merge 4 commits into from

Conversation

caufieldjh
Copy link
Contributor

@caufieldjh caufieldjh commented Oct 4, 2022 •
edited
Loading

  • Update run_classifier to use new grape methods
  • Remove obsoleted methods
  • Update tests and test fixtures
  • Include list of valid embedder and classifier names

This was linked to issues Oct 4, 2022
Update to use most recent grape functions for link prediction #97
Open
Drop support for Tensorflow and scikit-learn methods #98
Open
@caufieldjh
Copy link
Contributor Author

caufieldjh commented Oct 4, 2022 •
edited
Loading

I've been trying out configs with newer grape embedding methods but keep getting

NotImplementedError: None isn't implemented yet

suggesting that I'm just providing the wrong name, but I've run out of variations to try.
This should be documented anyway.

(This error is actually being thrown when the classifier model isn't recognized, though I'm just using Perceptron)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@caufieldjh