Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# RestSharp is using deprecated syntax #312

Open
jon-batscha opened this issue Feb 15, 2023 · 2 comments · Fixed by readmeio/httpsnippet#179
Open

C# RestSharp is using deprecated syntax #312

jon-batscha opened this issue Feb 15, 2023 · 2 comments · Fixed by readmeio/httpsnippet#179

Comments

@jon-batscha
Copy link

jon-batscha commented Feb 15, 2023

The example generated for this example is currently broken for folks using versions >= v107 of RestSharp. I have also seen the RestSharp generator break similarly for every other example i have tried, both directly in httpsnippet, as well as embedded in platforms.

This is due to breaking changes released in that version.

Is anyone currently working on a fix for this? Would love to connect.

Cheers!
Jon

@erunion
Copy link
Contributor

erunion commented Mar 8, 2023

@jon-batscha Would you be willing to submit a PR to fix this?

llimllib added a commit to readmeio/httpsnippet that referenced this issue Jun 16, 2023
Updates restsharp support following their breaking
changes, reported in Kong#312
@llimllib
Copy link

@jon-batscha an updated version has been merged into readmeio/httpsnippet, would love to know if it works for you

erunion added a commit to readmeio/httpsnippet that referenced this issue Jun 23, 2023
* feat: suppert restsharp 107+

Updates restsharp support following their breaking
changes, reported in Kong#312

* add 'using RestSharp'

* update fixtures

* add write response.content at end

* fix(clojure): don't crash if there's no postData content (#171)

* ci: extend ci testing to run on node 20

* build: 5.1.1 release

* feat: dropping support for node 14

* chore(deps): bumping out of date deps

* build: 6.0.0 release

* wip

* getting the csharp integration tests running

* if NODE_ENV=test, these no longer run

* better csharp dockerfile

* the postdata-malformed fixture shouldn't expect a content-type header

* hammering the int tests into shape

* add httpbin

* wip (see below for details)

- go-httpbin is using my local tag bc of mccutchen/go-httpbin#123
- go-httpbin incorrectly thinks our requests are coming in on plain http. Possibly https://stackoverflow.com/a/61446922 is the answer?
- getting close

* updating fixtures for different bin

* wip

* 17 of 18 shell tests passing

* add a reverse proxy so 80 and 443 both go to httpbin

* remove console

* update python output

.json() will parse the output _out_ of json and print it
as a python object, which our integration tests cannot
then parse

* more dockerfile updating

* tell requests to use our CA

* fix python whoopsie

* php tests pass

* tell node to use system ca certs

* update node dockerfile

* switch back to mccutchen

* format integration_test.sh

* fix WORKDIR order in node dockerfile

* remove logging

* now the node tests pass locally

* try adding a node install

I'm not sure why it builds locally but not on gh

* Revert "now the node tests pass locally"

- This broke a lot of other tests

This reverts commit 0d6670d.

* ah HA found it

* remove unnecessary volumes

* add comment

* remove merge artifact

* update csharp dockerfile

* integration test fixes + comments

* fix csharp content type and add newline at end

* fix postdata-malformed fixture

* add explicit json header

* get final tests to pass

* remove cli arg because I can't figure out how to update the snapshots

* fix content-type condition

* don't assert content type of no params test

* re-add cli arg

* jeez content-types are complicated

* update snapshot

* add c# dep on proxy

* un-change package-lock.json

---------

Co-authored-by: Jon Ursenbach <[email protected]>
Co-authored-by: Jon Ursenbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants