feat(clustering/sync): flatten and report validation error #14262
+316
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chobits
requested review from
flrgh and
chronolaw
and removed request for
flrgh
github-actions
bot
added
core/clustering
core/db
cherry-pick kong-ee
chronolaw
reviewed
Feb 12, 2025
|
We should open a same PR in CE. |
this is a CE pr now |
chronolaw
reviewed
Feb 12, 2025
| if not ok then | ||
| notify_error(ns_delta.lastest_version, err_t) |
There was a problem hiding this comment.
Which version should we use? dp's current version or delta's version?
There was a problem hiding this comment.
this lastest_version will be introduced by this rpc spec: https://github.com/Kong/openrpc_specfiles/pull/18
There was a problem hiding this comment.
https://github.com/Kong/kong-ee/pull/11238 introduces this new field
There was a problem hiding this comment.
if no this field, could we use deltas[#deltas].version?
|
For pre-running ee test cases, see this pr: https://github.com/Kong/kong-ee/pull/11363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
kong.sync.v2.notify_validation_error(spec: https://github.com/Kong/openrpc_specfiles/pull/18/)Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-6351 KAG-5898 KAG-6381