Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support controlplane reference of KIC type #6581

Open
2 of 4 tasks
Tracked by #6488
randmonkey opened this issue Oct 30, 2024 · 0 comments
Open
2 of 4 tasks
Tracked by #6488

Support controlplane reference of KIC type #6581

randmonkey opened this issue Oct 30, 2024 · 0 comments
Assignees
@czeslavo
Labels
area/CRD Changes in existing CRDs or introduction of new ones release/required it is required that this be resolved before releasing
Milestone
KIC v3.4.x

Comments

@randmonkey
Copy link
Contributor

randmonkey commented Oct 30, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

KIC should only reconcile Kong configuration CRDs with Control Plane type kic after migrated CRDs to Kong/kubernetes-configuration repo.

Dependent on #6578.

Proposed Solution

  • For each reconciler of Kong configuration CRD, do not reconcile CP ref with type iother than kic
  • Also reconcile CRD with empty (nil) CP ref to support existing CRDs before migrating to Kong/kubernetes-configuration repo

Additional information

No response

Acceptance Criteria

  • Kong configuration CRDs with type of controlPlaneRef other than kic are not reconciled by KIC
  • Existing CRDs before migration (without controlPlaneRef ) can still be reconciled by KIC if other condition (ingress class) satisfied
@randmonkey randmonkey added the area/CRD Changes in existing CRDs or introduction of new ones label Oct 30, 2024
@randmonkey randmonkey added this to the KIC v3.4.x milestone Oct 30, 2024
@randmonkey randmonkey mentioned this issue Oct 30, 2024
Open
5 tasks
@lahabana lahabana added the release/required it is required that this be resolved before releasing label Nov 13, 2024
@czeslavo czeslavo self-assigned this Nov 13, 2024
@czeslavo czeslavo removed the blocked label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czeslavo czeslavo

Labels
area/CRD Changes in existing CRDs or introduction of new ones release/required it is required that this be resolved before releasing
Projects
None yet
Milestone
KIC v3.4.x
Development

No branches or pull requests
3 participants
@lahabana @czeslavo @randmonkey