You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i found some discrepancies with the activation of air_absorption:
When using pra.Room.from_corners, the argument air_absorption=True can be set via initialization.
But to activate the air absorption at a different position in code I used the line room.air_absorption = True.
I already know that this is not the correct way to program this. To work properly I should use room.set_air_absorption()
I code on a Windows machine and run CI-tests on a linux server. I noticed room.air_absorption= True runs without an error on windows but raises TypeError: 'bool' object is not subscriptable on linux.
So I would suggest that the variable air_absorption of room should be a property without a setter method to prevent the use of room.air_absorption = True.
And do you have any idea why no error is raised when using Windows?
The text was updated successfully, but these errors were encountered:
Hi,
i found some discrepancies with the activation of air_absorption:
When using
pra.Room.from_corners
, the argumentair_absorption=True
can be set via initialization.But to activate the air absorption at a different position in code I used the line
room.air_absorption = True
.I already know that this is not the correct way to program this. To work properly I should use
room.set_air_absorption()
I code on a Windows machine and run CI-tests on a linux server. I noticed
room.air_absorption= True
runs without an error on windows but raisesTypeError: 'bool' object is not subscriptable
on linux.So I would suggest that the variable air_absorption of room should be a property without a setter method to prevent the use of
room.air_absorption = True
.And do you have any idea why no error is raised when using Windows?
The text was updated successfully, but these errors were encountered: