Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error checks for FE space ordering #1184

Open
zatkins-work opened this issue Jul 23, 2024 · 0 comments
Open

Add error checks for FE space ordering #1184

zatkins-work opened this issue Jul 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@zatkins-work
Copy link
Contributor

#1176 removes an error check in serac::FiniteElementVector which asserts that the DOF ordering is mfem::Ordering::byNODES. To prevent future regressions, we should do one (or both) of the following:

  1. Add back this error check, instead checking that the ordering matches serac::ordering
  2. Allow FiniteElementVector objects to have different orderings, but convert them to serac::ordering before using them. This is probably more complicated and error prone, but may be needed to support Tribol correctly.
@zatkins-work zatkins-work added the bug Something isn't working label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant