Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Button line-height is wrong #2

Open
vladshcherbin opened this issue Sep 7, 2017 · 10 comments
Open

Button line-height is wrong #2

vladshcherbin opened this issue Sep 7, 2017 · 10 comments
Assignees

Comments

@vladshcherbin
Copy link

Button line-height > button height, this prevents text from being vertically centered. Button is 32px, line-height is 34px.

screen shot 2017-09-08 at 1 10 09 am

@SerafimArts SerafimArts self-assigned this Sep 7, 2017
@SerafimArts SerafimArts added the bug label Sep 7, 2017
@SerafimArts
Copy link
Member

https://github.com/LaravelRUS/vue-ui/blob/master/src/components/Button.vue#L8-L9

Я добавлял это для того, чтобы на Linux и Windows текст был ровно по центру, на Mac OS походу не совсем так. Хз как тогда делать =\

@vladshcherbin
Copy link
Author

vladshcherbin commented Sep 7, 2017

@SerafimArts try line-height: 1

@SerafimArts
Copy link
Member

@vladshcherbin
image

@vladshcherbin
Copy link
Author

@SerafimArts hm, maybe line-height: 32px ?

@SerafimArts
Copy link
Member

@vladshcherbin есть идеи как задетектить макось?

@SerafimArts
Copy link
Member

SerafimArts commented Sep 7, 2017

@SerafimArts hm, maybe line-height: 32px ?

@vladshcherbin тоже самое. Я же выделил строчки - это специально так сделано =)

@vladshcherbin
Copy link
Author

@SerafimArts try removing line-height and add this:

display: flex;
flex-direction: column;
justify-content: center;
align-items: center;

screen shot 2017-09-08 at 1 29 12 am

Will it help?

@SerafimArts
Copy link
Member

display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
line-height: 32px;

Fixes this issue! 👍

@vladshcherbin
Copy link
Author

@SerafimArts unfortunately, display: flex can't be used for buttons as it also has some bugs 😞

@SerafimArts
Copy link
Member

lol? :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants