Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch some signatures to use ValueTask and implement IAsyncDisposable #124

Open
veikkoeeva opened this issue Aug 29, 2022 · 0 comments
Open

Switch some signatures to use ValueTask and implement IAsyncDisposable #124

veikkoeeva opened this issue Aug 29, 2022 · 0 comments

Comments

@veikkoeeva
Copy link
Contributor

At the moment (in did:key branch) while shaping APIs some API signatures (mostly delegates) that could end up calling asynchronous operations are synchronous. It would make sense to refactor these signatures to expose only ValueTask<T>. Accompanying this, code should add IAsyncDisposable in addition IDisposable. Something to consider either after or during did:key branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@veikkoeeva