Skip to content

Commit b5fbff5

Browse files
stigrjgitpeterwind
andauthored
Prepare v1.0.2 (#388)
* Bump Eigen to 3.4 (#387) * Compatibility with Eigen-3.4 * Bump MRCPP to 1.4 * Prepare v1.0.2 Co-authored-by: gitpeterwind <[email protected]>
1 parent 132d64f commit b5fbff5

9 files changed

+33
-58
lines changed

.circleci/config.yml

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
version: 2
22

33
variables:
4-
ubuntu-1804: &ubuntu-1804
4+
ubuntu-2004: &ubuntu-2004
55
docker:
6-
- image: quay.io/metamr/circleci_ubuntu-18.04:f969788
6+
- image: ghcr.io/mrchemsoft/metamr/circleci_ubuntu-20.04:sha-343e011
77
name: tsubame
88
user: merzbow
99
working_directory: ~/mrchem
@@ -12,7 +12,7 @@ variables:
1212
name: Configuring serial
1313
shell: /bin/bash
1414
command: |
15-
python3 setup \
15+
python setup \
1616
--type=release \
1717
--cxx=g++ \
1818
--prefix=$HOME/Software/MRChem
@@ -21,7 +21,7 @@ variables:
2121
name: Configuring OpenMP parallel
2222
shell: /bin/bash
2323
command: |
24-
python3 setup \
24+
python setup \
2525
--type=release \
2626
--cxx=g++ \
2727
--omp \
@@ -31,7 +31,7 @@ variables:
3131
name: Configuring MPI parallel
3232
shell: /bin/bash
3333
command: |
34-
python3 setup \
34+
python setup \
3535
--type=release \
3636
--cxx=mpicxx \
3737
--mpi \
@@ -52,14 +52,14 @@ variables:
5252
5353
jobs:
5454
serial-py3:
55-
<<: *ubuntu-1804
55+
<<: *ubuntu-2004
5656
steps:
5757
- checkout
5858
- *configure-serial
5959
- *build
6060
- *tests
6161
omp-py3:
62-
<<: *ubuntu-1804
62+
<<: *ubuntu-2004
6363
environment:
6464
- OMP_NUM_THREADS: '2'
6565
steps:
@@ -68,7 +68,7 @@ jobs:
6868
- *build
6969
- *tests
7070
mpi-py3:
71-
<<: *ubuntu-1804
71+
<<: *ubuntu-2004
7272
steps:
7373
- checkout
7474
- *configure-mpi

CHANGELOG.md

+11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# Change log
22

3+
## Version 1.0.2 2021-10-13
4+
5+
### Changed
6+
7+
- Updated MRCPP to v1.4.0
8+
- Updated Eigen to v3.4.0
9+
10+
### Fixed
11+
12+
- Compile error with Eigen-3.4 due to conversion std::array<double> -> Eigen::VectorXd
13+
314
## Version 1.0.1 2020-12-04
415

516
### Changed

CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Copyright (c) 2015-2020 by Radovan Bast, Roberto Di Remigio, Jonas Juselius, and contributors.
33

44
# set minimum cmake version
5-
cmake_minimum_required(VERSION 3.12 FATAL_ERROR)
5+
cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
66

77
# project name
88
project(MRChem LANGUAGES CXX)

VERSION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.0.1
1+
1.0.2

cmake/autocmake.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: MRChem
22
language: CXX
3-
min_cmake_version: 3.12
3+
min_cmake_version: 3.14
44
setup_script: setup
55
default_build_type: release
66

external/upstream/eigen-config-cmake.patch

-26
This file was deleted.

external/upstream/fetch_eigen3.cmake

+8-18
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,20 @@
1-
find_package(Eigen3 3.3 CONFIG QUIET NO_CMAKE_PACKAGE_REGISTRY)
1+
find_package(Eigen3 3.4 CONFIG QUIET
2+
NO_CMAKE_PATH
3+
NO_CMAKE_PACKAGE_REGISTRY
4+
)
5+
26
if(TARGET Eigen3::Eigen)
37
message(STATUS "Using Eigen3: ${EIGEN3_ROOT_DIR} (version ${Eigen3_VERSION})")
48
else()
59
message(STATUS "Suitable Eigen3 could not be located. Fetching and building!")
610
include(FetchContent)
711

8-
FetchContent_Declare(eigen3_sources
12+
FetchContent_Declare(eigen3
913
QUIET
1014
URL
11-
https://gitlab.com/libeigen/eigen/-/archive/3.3.7/eigen-3.3.7.tar.gz
12-
PATCH_COMMAND patch -p1 < ${CMAKE_CURRENT_LIST_DIR}/eigen-config-cmake.patch
15+
https://gitlab.com/libeigen/eigen/-/archive/3.4.0/eigen-3.4.0.tar.gz
1316
)
1417

15-
FetchContent_GetProperties(eigen3_sources)
16-
1718
set(BUILD_TESTING OFF CACHE BOOL "" FORCE)
18-
19-
if(NOT eigen3_sources_POPULATED)
20-
FetchContent_Populate(eigen3_sources)
21-
22-
add_subdirectory(
23-
${eigen3_sources_SOURCE_DIR}
24-
${eigen3_sources_BINARY_DIR}
25-
)
26-
endif()
27-
# Provide an alias, so linking to Eigen looks the same regardless if it was
28-
# found on the system or if it was fetched at configuration
29-
add_library(Eigen3::Eigen ALIAS eigen)
19+
FetchContent_MakeAvailable(eigen3)
3020
endif()

external/upstream/fetch_mrcpp.cmake

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
find_package(MRCPP CONFIG QUIET
1+
find_package(MRCPP 1.3 CONFIG QUIET
22
NO_CMAKE_PATH
33
NO_CMAKE_PACKAGE_REGISTRY
44
NO_CMAKE_SYSTEM_PACKAGE_REGISTRY
@@ -37,7 +37,7 @@ else()
3737
FetchContent_Declare(mrcpp_sources
3838
QUIET
3939
URL
40-
https://github.com/MRChemSoft/mrcpp/archive/v1.3.6.tar.gz
40+
https://github.com/MRChemSoft/mrcpp/archive/v1.4.0.tar.gz
4141
)
4242

4343
FetchContent_GetProperties(mrcpp_sources)

src/driver.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -969,7 +969,7 @@ void driver::build_fock_operator(const json &json_fock, Molecule &mol, FockOpera
969969
///////////////// External Operator ///////////////////
970970
///////////////////////////////////////////////////////////
971971
if (json_fock.contains("external_operator")) {
972-
auto field = json_fock["external_operator"]["electric_field"];
972+
auto field = json_fock["external_operator"]["electric_field"].get<std::array<double, 3>>();
973973
auto r_O = json_fock["external_operator"]["r_O"];
974974
auto V_ext = std::make_shared<ElectricFieldOperator>(field, r_O);
975975
F.getExtOperator() = V_ext;

0 commit comments

Comments
 (0)