Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark unsupported serialization implementations as obsolete to remove them in another major version #4236

Open
StefanOssendorf opened this issue Sep 29, 2024 · 1 comment

Comments

@StefanOssendorf
Copy link
Contributor

StefanOssendorf commented Sep 29, 2024

As discussed with rocky we should mark

  • CslaLegacyBinaryReader
  • CslaLegacyBinaryWriter
    as obsolete with a hint that they will be removed in the next major version.

Furthermore we still have some DataContractSerializer (DCS) remnants in the project.
That means the two classes

  • CslaXmlBinaryReader
  • CslaXmlBinaryWriter
  • CslaXmlWriter
  • CslaXmlReader

should also be marked as obsolete.

In addition to that the static factory method creating the DCS must also be marked as obsolete.

  • CslaReaderWriterFactory.GetDataContractSerializer()
@StefanOssendorf
Copy link
Contributor Author

StefanOssendorf commented Sep 29, 2024

@rockfordlhotka Please check the last 4 reader/writes I mentioned in the issue. Marking them as obsolete would mean only CslaBinaryWriter/Reader is currently a valid implementation within CSLA itself 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant